Adjust tvg compatibility btarget#692
Merged
Rick-Methot-NOAA merged 8 commits intomainfrom Jul 28, 2025
Merged
Conversation
adjust conditions for compatibility in the Btarget reference point calculations
iantaylor-NOAA
approved these changes
Jul 23, 2025
Contributor
iantaylor-NOAA
left a comment
iantaylor-NOAA
left a comment
There was a problem hiding this comment.
The changes look OK to me but I'm definitely out of my depth with this section of the code.
Contributor
|
Tagging @alexjensen-NOAA so you can see progress on this fix. |
added 4 commits
July 24, 2025 10:54
Collaborator
|
@Rick-Methot-NOAA I'm working on why the build-warnings is failing. The GHA is behaving differently than running the workflow on codespaces is (which shouldn't be the case) but that is making it hard to debug. |
added 2 commits
July 24, 2025 17:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely describe what has been changed/addressed in the pull request.
Adjust usage of the timevary growth compatibility flag such that Btarget will default to the same as it occurs in legacy SS3 before 3.30.24.
What tests have been done?
Where are the relevant files?
<-- - [x] No test files are required for this pull request. --I did a local test using the Pmack files from A Jensen>
What tests/review still need to be done?
Check logic of the revised conditional statement.
Is there an input change for users to Stock Synthesis?
<-- - [x] No, there was no input change. -->
Additional information (optional).