bypass steepness calcs when steepness == 1#697
Merged
Rick-Methot-NOAA merged 4 commits intomainfrom Aug 7, 2025
Merged
Conversation
Collaborator
|
I need to test this early next week but I think this fails because the test models haven't all been updated to the pre-release. I will create a branch in test models and run the est and no est models on that on monday to see if I can get this passing again. |
e-perl-NOAA
force-pushed
the
689-33024pre-fails-with-steepness-100
branch
from
e998815 to
a845a75
Compare
Collaborator
|
@Rick-Methot-NOAA running this again this morning locally and on a codespace testing with the Sablefish2015, I am getting log likelihood differences with this exe. |
Collaborator
Author
|
found and fixed a logic error regarding the bypassing of steepness |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely describe what has been changed/addressed in the pull request.
Add flag to bypass steepness calcs if steepness == 1, not estimated, and sr_fxn = 3.
What tests have been done?
Where are the relevant files?
<-- - [x] No test files are required for this pull request. -->
What tests/review still need to be done?
none
Is there an input change for users to Stock Synthesis?
<-- - [x] No, there was no input change. -->
Additional information (optional).