Skip to content

remove unneeded natatage()=0#701

Merged
Rick-Methot-NOAA merged 2 commits intomainfrom
700-bug-33024-prerelease-difference-in-seasonal-model-forecasts
Aug 12, 2025
Merged

remove unneeded natatage()=0#701
Rick-Methot-NOAA merged 2 commits intomainfrom
700-bug-33024-prerelease-difference-in-seasonal-model-forecasts

Conversation

@Rick-Methot-NOAA
Copy link
Copy Markdown
Collaborator

Concisely describe what has been changed/addressed in the pull request.

What tests have been done?

detailed examination of natage tables using the two season sardine example that has spawning at beginning of season 2 and recruitment at age 0 at the beginning of the following year.

Where are the relevant files?

<-- - [x] No test files are required for this pull request. -->

What tests/review still need to be done?

Is there an input change for users to Stock Synthesis?

<-- - [x] No, there was no input change. -->

Additional information (optional).

@Rick-Methot-NOAA
Copy link
Copy Markdown
Collaborator Author

Caitlin - I vaguely recall that sardine uses a six-month shifted calendar, i.e. Jan is really July. Is that true? Also review the logic behind saying that they are ae 0 , not age 1, on their first January. Then they are age 18 months when they first spawn still at age 0.

@CaitlinAkselrud-NOAA
Copy link
Copy Markdown

CaitlinAkselrud-NOAA commented Aug 11, 2025 via email

@Rick-Methot-NOAA Rick-Methot-NOAA merged commit aa748f3 into main Aug 12, 2025
13 checks passed
@Rick-Methot-NOAA Rick-Methot-NOAA deleted the 700-bug-33024-prerelease-difference-in-seasonal-model-forecasts branch August 12, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 3.30.24 prerelease difference in seasonal model forecasts

2 participants