Skip to content

Try fixing test simple model with artifacts; add qpdf to build admb and ss3 from source workflow#705

Merged
e-perl-NOAA merged 8 commits intomainfrom
test-simple-with-artifacts-fix
Aug 19, 2025
Merged

Try fixing test simple model with artifacts; add qpdf to build admb and ss3 from source workflow#705
e-perl-NOAA merged 8 commits intomainfrom
test-simple-with-artifacts-fix

Conversation

@e-perl-NOAA
Copy link
Copy Markdown
Collaborator

Concisely describe what has been changed/addressed in the pull request.

  • The build-admb-and-ss3-from-source workflow runs weekly. This action failed for the macos-13 runner and needed to add qpdf in order to get it to pass
  • The workflow to test build-ss3 with the simple model on all operating systems started failing 3 weeks ago and I have no idea why. A shortcoming of github actions is to try to even troubleshoot and fix bugs, they have to be on the main branch when using the workflow-dispatch trigger which means this might be one of many PRs trying to resolve the issue with this action failing.

What tests have been done?

Where are the relevant files?

  • No test files are required for this pull request. -->

What tests/review still need to be done?

None.

Is there an input change for users to Stock Synthesis?

  • No, there was no input change. -->

Additional information (optional).

@e-perl-NOAA e-perl-NOAA force-pushed the test-simple-with-artifacts-fix branch from cba4499 to f39a5c7 Compare August 19, 2025 16:38
@e-perl-NOAA e-perl-NOAA added the workflows related to workflows/gh-actions label Aug 19, 2025
Copy link
Copy Markdown
Collaborator

@Rick-Methot-NOAA Rick-Methot-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wish I could help. Is there an opportunity to request support from Scott Sauri's group?

@e-perl-NOAA
Copy link
Copy Markdown
Collaborator Author

We are on our own when it comes to GitHub actions, it also doesn't help that this particular workflow trigger will only run on main, which is something on the GitHub side. It's not an issue/bug, it's just what the set it up to do.

@e-perl-NOAA e-perl-NOAA merged commit 6747af7 into main Aug 19, 2025
2 checks passed
@e-perl-NOAA e-perl-NOAA deleted the test-simple-with-artifacts-fix branch August 19, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workflows related to workflows/gh-actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants