remove settlement warning that can be misleading#710
Merged
Rick-Methot-NOAA merged 3 commits intomainfrom Aug 25, 2025
Merged
Conversation
e-perl-NOAA
approved these changes
Aug 25, 2025
Rick-Methot-NOAA
deleted the
remove_misleading_warning_settlement_timing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely describe what has been changed/addressed in the pull request.
A warning regarding settlement age could be misleading. If spawn month is <= settlement month, then it is OK for age at setlement to be 0 or 1. Previously, a warning got issued in some plausible situations.
no issue. but related to [Bug]: error in time delay between spawning and settlement when settlement age is not equal to 0 #691 and [Bug]: 3.30.24 prerelease difference in seasonal model forecasts #700
What tests have been done?
none needed
Where are the relevant files?
<-- - [x] No test files are required for this pull request. -->
What tests/review still need to be done?
Is there an input change for users to Stock Synthesis?
<-- - [x] No, there was no input change. -->
Additional information (optional).