Skip to content

[Fix] bugs identified in plot_recruitment#220

Merged
Schiano-NOAA merged 6 commits intodevfrom
fix-rec-plt
Apr 3, 2026
Merged

[Fix] bugs identified in plot_recruitment#220
Schiano-NOAA merged 6 commits intodevfrom
fix-rec-plt

Conversation

@Schiano-NOAA
Copy link
Copy Markdown
Collaborator

Address the bugs identified in plot recruitment (#211 and #215)

  • A leftover hard-coded value from testing was in the function. This has now been removed.
  • A condition for models that properly sets grouping was added including testing conditions when indexing variables are indicated, but don't actually have unique values.
  • the plot was also changed to only search for "recruitment$"

@Schiano-NOAA Schiano-NOAA changed the title Fix rec plt [Fix] bugs identified in plot_recruitment Apr 3, 2026
@Schiano-NOAA Schiano-NOAA marked this pull request as ready for review April 3, 2026 15:24
Copy link
Copy Markdown
Collaborator

@sbreitbart-NOAA sbreitbart-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Schiano-NOAA Schiano-NOAA merged commit fe7e146 into dev Apr 3, 2026
1 check passed
@Schiano-NOAA Schiano-NOAA deleted the fix-rec-plt branch April 3, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plot_recruitment() plots black lines for all models in list plot_recruitment does not group lists

2 participants