Don't generally require args and paths to be valid UTF-8, remove dependency on camino#33
Open
alurm wants to merge 1 commit intonoamraph:masterfrom
Open
Don't generally require args and paths to be valid UTF-8, remove dependency on camino#33alurm wants to merge 1 commit intonoamraph:masterfrom
alurm wants to merge 1 commit intonoamraph:masterfrom
Conversation
…ndency on camino
OsStr and OsString is used instead.
"_utf8" versions of functions are replaced with their regular versions.
Paths are printed with {:?} in logs and errors.
NIXSA_BWRAP_ARGS is still required to be UTF-8.
quote() still returns String, but is expected to perform a proper conversion from OsString under the hood.
Closes noamraph#32.
Author
|
I haven't tested this yet. I'll be testing it now. |
Author
|
Some parts of this definitely work: What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OsStr and OsString is used instead.
"_utf8" versions of functions are replaced with their regular versions. Paths are printed with {:?} in logs and errors.
NIXSA_BWRAP_ARGS is still required to be UTF-8.
quote() still returns String, but is expected to perform a proper conversion from OsString under the hood.
Closes #32.