Skip to content

feature(w-engine): add page gestion - #414

Open
Tadomika-Ari wants to merge 9 commits into
noctalia-dev:mainfrom
Tadomika-Ari:feature/fix-load-all-wallpaper
Open

feature(w-engine): add page gestion#414
Tadomika-Ari wants to merge 9 commits into
noctalia-dev:mainfrom
Tadomika-Ari:feature/fix-load-all-wallpaper

Conversation

@Tadomika-Ari

@Tadomika-Ari Tadomika-Ari commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Plugin

  • Id: <author>/<plugin>
  • New plugin
  • Update to an existing plugin (version bumped in plugin.toml)

What it does

Add a page management feature for limited wallpaper viewing.

This update fixes a crash that occurs for users who have a large number of wallpapers in the Steam Workshop and the plugin crashes after (for example) attempting to load 200 wallpapers.

To fix this, I added a function that checks whether the wallpaper is within the trigger zone while adding it in the loop. I check if the wallpaper number falls within the range of MAX_WALLPAPER_SHOW * PAGE_NUMBER and MAX_WALLPAPER * PAGE_NUMBER - MAX_WALLPAPER_SHOW.

I also added a limit to prevent navigation when no more pages are available.

Note: #390 (comment)

External dependencies

Testing

  • Tested on Niri
  • Tested on Hyprland
  • Tested on Sway
  • Tested on another compositor:
  • Noctalia version tested against:
  • Plugin API level:

Screenshots / Videos

Checklist

Ready-for-review requirement: Every box in this section must be checked. If any statement is not true, keep the
pull request as Draft. An explanation does not replace a required check.

  • The directory name matches the part of id after the / in plugin.toml exactly.
  • It ships plugin.toml, README.md, thumbnail.webp, and translations/en.json.
  • README.md follows the
    README template, documents
    every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
  • I created thumbnail.webp with the thumbnail generator.
  • version follows semver and is bumped in this PR; plugin_api is the oldest API level this plugin requires.
  • Every non-English translation in this PR uses a locale supported by Noctalia core, and I can read, write, and
    understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
  • I did not edit catalog.toml; CI generates it.
  • This PR touches exactly one plugin directory.

Code review attestation

Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
Ready-for-review requirement: Every attestation below must be checked.

  • The code is readable and not obfuscated, minified, or generated.
  • It does not download and execute remote code.
  • Every network call, filesystem write, and spawned process is something the description above accounts for.
  • I have the right to publish this code under the license declared in plugin.toml.

@Tadomika-Ari
Tadomika-Ari marked this pull request as draft August 19, 2026 22:42
@Tadomika-Ari
Tadomika-Ari marked this pull request as ready for review August 20, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant