fix(mihomo-control): restore service load in v0.1.3 - #420
Open
mdj2812 wants to merge 1 commit into
Open
Conversation
Fix Luau syntax errors in self-test calls and load group helpers via require() so the service entry starts and publishes online state again. Co-authored-by: Cursor <cursoragent@cursor.com>
mdj2812
marked this pull request as ready for review
August 20, 2026 14:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin
mdj2812/mihomo-controlplugin.toml)What it does
Hotfix for a v0.1.2 regression where the Mihomo Control service entry failed to load, leaving the widget stuck offline even when the external controller was reachable.
run_self_test()that madeservice.luaufailluau_loadrequire("./group_logic.luau")instead of sandbox-unavailableload()group_logic.lua→group_logic.luauso Noctalia can require the module0.1.3External dependencies
None — same HTTP-only Mihomo external controller integration as before.
Testing
Verified the service log reports
self-test passed (4 checks)and the widget tooltip shows online against a remote HTTPS controller (openclash.home.mdj2812.top:443).Screenshots / Videos
N/A — service-only hotfix. Connection status verified via widget tooltip and service logs after reload.
Checklist
Ready-for-review requirement: Every box in this section must be checked. If any statement is not true, keep the
pull request as Draft. An explanation does not replace a required check.
idafter the/inplugin.tomlexactly.plugin.toml,README.md,thumbnail.webp, andtranslations/en.json.README.mdfollows theREADME template, documents
every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
thumbnail.webpwith the thumbnail generator.versionfollows semver and is bumped in this PR;plugin_apiis the oldest API level this plugin requires.understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
catalog.toml; CI generates it.Code review attestation
Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
Ready-for-review requirement: Every attestation below must be checked.
licensedeclared inplugin.toml.Made with Cursor