Skip to content

feat: add default_maximize_to_edges window rule - #4

Open
Yocraft-2000 wants to merge 4 commits into
noctalia-dev:mainfrom
Yocraft-2000:maximize_to_edges_window_rule
Open

feat: add default_maximize_to_edges window rule#4
Yocraft-2000 wants to merge 4 commits into
noctalia-dev:mainfrom
Yocraft-2000:maximize_to_edges_window_rule

Conversation

@Yocraft-2000

@Yocraft-2000 Yocraft-2000 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Added the default_maximize_to_edges window rule.

Motivation

The window-toggle-maximize-to-edges shortcut was added but not the window rule.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Build / packaging
  • Documentation

Related Issue

Testing

I added a window rule using default_maximize_to_edges and the window opened maximized to edges.

Manual Coverage

  • Tested in a nested Umbriel session
  • Tested in a native Umbriel session
  • Tested with multiple monitors
  • Tested with a scaled output
  • Tested with native Wayland applications
  • Tested with X11 applications through xwayland-satellite
  • Tested with the scrolling layout
  • Tested with the dwindle layout

Screenshots / Videos

Checklist

  • This PR is ready for review, or it is marked as Draft.
  • I read and followed the relevant guidance in CONTRIBUTING.md.
  • I initialized and updated the SceneFX submodule where required.
  • I ran just format, or this PR has no C++ changes.
  • I ran the relevant build, test, lint, or verification commands, or explained why they were not run.
  • I functionally verified compositor behavior where automated checks are insufficient.
  • I self-reviewed the changes.
  • I checked for new warnings or errors.
  • I updated docs/ and examples/config.toml, or this PR does not change user-facing configuration or behavior.
  • I used canonical names for config keys, IPC actions, paths, and identifiers.

Additional Notes

@Yocraft-2000
Yocraft-2000 marked this pull request as ready for review August 22, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant