Skip to content

Conversation

@efekrskl
Copy link
Contributor

Fixes #61224

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Dec 31, 2025
@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (7b7f693) to head (4d65e94).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61230      +/-   ##
==========================================
- Coverage   88.54%   88.52%   -0.02%     
==========================================
  Files         704      704              
  Lines      208738   208742       +4     
  Branches    40278    40280       +2     
==========================================
- Hits       184833   184797      -36     
- Misses      15914    15957      +43     
+ Partials     7991     7988       -3     
Files with missing lines Coverage Δ
lib/internal/fs/promises.js 98.14% <100.00%> (ø)

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Renegade334
Copy link
Member

Might be worth checking that there are no others from #52135 that were missed.

@Renegade334 Renegade334 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Dec 31, 2025
@targos
Copy link
Member

targos commented Dec 31, 2025

v22 is affected by the bug, why dont-land?

@Renegade334 Renegade334 removed the dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. label Dec 31, 2025
@Renegade334
Copy link
Member

Indeed, I managed to parse as v23.x for some reason.

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test so that this doesn't regress again.

@efekrskl
Copy link
Contributor Author

Might be worth checking that there are no others from #52135 that were missed.

I've checked the other changes, and I don't think any other were missed.

@efekrskl
Copy link
Contributor Author

Can you add a test so that this doesn't regress again.

Good point, just pushed a test

@efekrskl efekrskl requested a review from cjihrig December 31, 2025 17:24
Copy link
Member

@LiviaMedeiros LiviaMedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the nit.

Co-authored-by: Livia Medeiros <livia@cirno.name>
@efekrskl efekrskl requested a review from LiviaMedeiros January 2, 2026 17:02
@LiviaMedeiros LiviaMedeiros added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 2, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2026
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fs::StatFs promise crashes v8 with incorrect argument

8 participants