lib: fix phantom EACCES on spawn in some environments #61253
+140
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some Linux environments (e.g. WSL), execvp may return EACCES instead of ENOENT when a command is not found in PATH, if it encounters permission errors during the search. This change adds a check to verify if the file actually exists in PATH when EACCES is received for a command without path separators. If not found, the error is normalized to ENOENT.
refs: https://gist.github.com/watilde/db38ff0335834a32a6eebaa6b3373b8b
Once this is merged, I plan to add a CI setup for the WSL Distribution, which I believe will have a fair amount of users.