Repository navigation
fix: container detail shows live CPU/Mem + adds Network/Disk I/O (0.1.40-beta6) - #205
Merged
Merged
Conversation
The detail sheet read CPU/Memory off the polled Container (c.cpu/c.memMb), which GetDockerContainers hardcodes to 0 — so running containers showed 0%. Feed it the dockerContainerStats overlay instead (reactive: the open sheet recomposes as frames land), and carry netIO/blockIO — already selected by the subscription op but dropped by the mapper — through ContainerLiveStats so the sheet can add Network and Disk I/O blocks. Stopped/no-frame -> "—". ADR-0044. Docker tab rows unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The container detail sheet showed 0 for CPU/Memory because it read the polled Container fields (hardcoded 0) instead of the live dockerContainerStats overlay; now it pulls live stats from dockerLiveStats[id] (reactive) and additionally surfaces Network I/O (netIO, RX/TX) and Disk I/O (blockIO, read/write) which the subscription already delivered but the mapper dropped; rows unchanged; builds on the 0.1.40 cycle (ADR-0044).
🤖 Generated with Claude Code