Repository navigation
fix: show the cause of request errors and keep the mode on the pill - #218
Merged
Merged
Conversation
#217: every tab failed with "Error while reading JSON response" while the connection test passed. Two things made that undiagnosable: - Apollo wraps any parsing failure in that generic message and keeps the reason only in the cause, which the app dropped. Errors now carry the innermost cause ("... (EOFException: End of input ...)"), capped at 200 characters. - The connection pill showed a bare "Offline", hiding whether the app was polling the local or the remote address, although the test in the server sheet only checks the URL being edited. It now reads "Local · Offline" / "Remote · Offline". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #217.
Every tab failed with "Error while reading JSON response" while the connection test passed, and the report could not be narrowed down from the app:
Throwable.failureMessage()appends the innermost cause (type + message, capped at 200 chars); used for polling errors, the connection test and response classification.connectionLabel(), extracted fromTopBar).Tests:
ResponseClassifierTest(+3: root cause shown, cause without message, long cause capped), newConnectionLabelTest(3)../scripts/local-ci.shpassed (build, lint, unit tests).UI change (pill text): needs the on-device acceptance pass before release.
🤖 Generated with Claude Code