Skip to content

feat: allow switching into hover window via ctrl+w w for long translasion #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
code-dom wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: allow switching into hover window via ctrl+w w for long translasion #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d96046
feat: allow switching into hover window via ctrl+w w for long transla…
code-dom Mar 30, 2026
cd96ffa
fix: 1.use WinEnter only for hover close 2.add BufLeave / Winleave fo…
code-dom Apr 19, 2026
f3d0563
feat: add timer/cleanup test
code-dom Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions lua/comment-translate/autocmds.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ function M.setup_hover(config, parser, translate, ui)
group = hover_group,
callback = function()
local bufnr = vim.api.nvim_get_current_buf()
if bufnr == ui.hover.bufnr() then
return
end
cleanup_timer(bufnr)

vim.defer_fn(function()
Expand All @@ -89,27 +92,23 @@ function M.setup_hover(config, parser, translate, ui)
group = hover_group,
callback = function(args)
cleanup_timer(args.buf)
if ui.hover.bufnr() ~= args.buf then
ui.hover.close()
end
end,
})

vim.api.nvim_create_autocmd('BufDelete', {
vim.api.nvim_create_autocmd('WinEnter', {
group = hover_group,
callback = function()
local bufnr = vim.api.nvim_get_current_buf()
cleanup_timer(bufnr)
if bufnr ~= ui.hover.bufnr() then
ui.hover.close()
end
end,
})

vim.api.nvim_create_autocmd('BufWipeout', {
vim.api.nvim_create_autocmd('BufDelete', {
group = hover_group,
callback = function(args)
cleanup_timer(args.buf)
if ui.hover.bufnr() ~= args.buf then
ui.hover.close()
end
callback = function()
local bufnr = vim.api.nvim_get_current_buf()
cleanup_timer(bufnr)
end,
})

Expand Down
8 changes: 8 additions & 0 deletions lua/comment-translate/ui/hover.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,14 @@ function M.show(text, opts)
vim.wo[hover_winid].relativenumber = false
vim.wo[hover_winid].cursorline = false
vim.wo[hover_winid].winhighlight = 'Normal:NormalFloat'

for _, key in ipairs({ 'q', '<Esc>' }) do
vim.keymap.set('n', key, M.close, {
buffer = hover_bufnr,
silent = true,
desc = 'Comment Translate: close hover',
})
end
end

return M
Loading