Conversation
Some tests failed on Windows machines due to hardcoded POSIX path separators and assumptions about drive letters. Normalize test expectations across the suite: - internal/cache: use native path separators with filepath.Join and filepath.FromSlash for cache directory lookups. - internal/fs: construct file URIs using span.URIFromPath to properly encode Windows drive letters, and normalize path expectations in TestJoinPath and TestTTCN3Files with filepath.FromSlash. - internal/lsp: normalize expected file paths in hover tests with filepath.FromSlash, and dynamically determine the working drive in uri_windows_test.go so tests pass on CI runners using D:\. - project: use filepath.FromSlash for relative hooks_file assertions and handle Windows relative path behavior for "/file". - ci: add windows-latest to the test matrix, and enable Git core.longpaths on Windows before checkout to handle long paths in conformance tests. Fixes nokia#629
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #629 by resolving test failures on Windows caused by hardcoded POSIX path separators and drive letter assumptions, and adds Windows to the GitHub Actions CI matrix.
Summary of Changes
filepath.Joinandfilepath.FromSlash.span.URIFromPathinTestBytesFromURLto encode Windows drive letters properly; normalize expectations inTestJoinPathandTestTTCN3Fileswithfilepath.FromSlash.filepath.FromSlash. Dynamically derive the working drive inuri_windows_test.goso tests succeed on runners usingD:\.filepath.FromSlashfor relativehooks_fileassertions and account for Windows relative path semantics for"/file".windows-latest(andmacos-latest) to the CI test matrix. Enable Gitcore.longpathson Windows beforeactions/checkoutto support deep paths intestdata/ttcn3-conformance-tests/.Closes #629