fix(windows): vswhere detection + winget build-tools install; reconcile fork-origin onto current main

[noogalabs]

What & why

Reconciles the field-proven Windows installer fix (PR #1 fix/windows-install-mjs, which got Foothills PM running on Windows) onto current main, and adds the Windows guide (PR #2 docs/windows-install-guide). PR #1 didn't cherry-pick cleanly because main already had a simpler post-rename origin check while PR #1 carried richer logic against the old pre-rename name. Resolved by hand.

Blast radius note: install.mjs is the live public install script every new member runs. Mac/Linux zero-regression is the gate, and is verified byte-level below.

1. Windows build-tools block — before/after

The dead npm install -g windows-build-tools package (long deprecated/removed) is GONE. Replaced with vswhere DETECTION + winget install.

Before (main):

// Check for Windows Build Tools
let hasBuildTools = false;
try { run('cl.exe /? 2>&1'); hasBuildTools = true; } catch {}
try { run('where cl.exe'); hasBuildTools = true; } catch {}
...
console.log(`    ${Y}  npm install -g windows-build-tools${R}`);
...
if (tryAuto) { runVisible('npm install -g windows-build-tools'); ... }

After (this branch):

// cl.exe is only on PATH inside a Developer PowerShell — fall back to vswhere.
let hasBuildTools = false;
try { run('where cl.exe'); hasBuildTools = true; } catch {}
if (!hasBuildTools) {
  const vswhere = join(process.env['ProgramFiles(x86)'] || 'C:\\Program Files (x86)',
    'Microsoft Visual Studio', 'Installer', 'vswhere.exe');
  if (existsSync(vswhere)) {
    try {
      const vcPath = run(`${JSON.stringify(vswhere)} -latest -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath`);
      if (vcPath) hasBuildTools = true;
    } catch {}
  }
}
...
console.log(`    ${Y}  winget install Microsoft.VisualStudio.2022.BuildTools --override "--passive --wait --add Microsoft.VisualStudio.Workload.VCTools --includeRecommended"${R}`);
...
if (tryAuto) { runVisible('winget install Microsoft.VisualStudio.2022.BuildTools --override "..."'); }

The final C++-compilation-error hint (was L613) was also switched from the dead npm package to the winget command. AUTO_BUILD_TOOLS=1 env gate is retained — it now triggers the winget auto-install, not the dead package.

2. Resolved fork-origin block

Kept PR #1's richer isCanonicalOrigin / isForkOrigin logic (handles a personal fork as origin → adds canonical upstream instead of silently skipping migration), but corrected the repo-name references to the post-rename noogalabs/ascendops (PR #1 referenced the old noogalabs/ascendops-install). Main's existing canonical-match behavior (includes('noogalabs/ascendops'), grandamenium/cortextos, === REPO_URL) is preserved verbatim — the new branch only adds the fork case on top.

const repoName = REPO_URL.replace(/^https:\/\/github\.com\//, '').replace(/\.git$/, '').split('/').pop();
const isCanonicalOrigin = !!originUrl && (
  originUrl.includes('noogalabs/ascendops') ||
  originUrl.includes('grandamenium/cortextos') ||
  originUrl === REPO_URL
);
const isForkOrigin = !!originUrl && !isCanonicalOrigin && (
  originUrl.endsWith(`/${repoName}.git`) || originUrl.endsWith(`/${repoName}`)
);
if (isCanonicalOrigin) { /* rename origin -> upstream (unchanged from main) */ }
else if (isForkOrigin) { /* add canonical as upstream, keep fork as origin */ }

3. Mac/Linux paths untouched — verification

The full diff to install.mjs is exactly these hunks (git diff main):

@@ -261,39 +261,57 @@ if (IS_MAC) {     # Windows build-tools block only
@@ -480,10 +498,23 @@ ...                # fork-origin block
@@ -492,6 +523,17 @@ ...                 # fork-origin block (cont.)
@@ -609,8 +651,8 @@ try {              # Windows-only final-error hint

All four hunks are inside the IS_WINDOWS branch or the fork-origin migration block. A line-by-line script that strips those three regions from both main and this branch confirms the remainder is byte-identical — the only other delta is the deliberate removal of one now-inaccurate comment line in the fork block. The IS_MAC (brew/xcode-select) and IS_LINUX (apt-get/build-essential) paths are unchanged.

No ascendops-install regression in install.mjs (main's canonical name preserved). Guide install URLs updated to the canonical name.

4. Gates

• node --check install.mjs → CLEAN
• No secrets/keys in the diff (scanned).

Do not merge — leaving for human review.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 24a4ac72a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Add WSL to the Windows setup path

For a zero-start Windows machine without WSL, this guide walks through only Node, Git, and Visual C++ Build Tools before running the installer, but the installer itself checks wsl and warns that “agents will not work without it on Windows” because shell scripts run in bash. Following this guide as written can therefore complete the install flow and proceed to onboarding with a fleet that cannot run its Windows shell-script dependency; add a WSL install/restart step before Step 6 or list it as a required prerequisite here.

Useful? React with 👍 / 👎.