Skip to content

fix(install): Windows WSL check → bash-environment check (Git Bash is the default) - #4

Draft
noogalabs wants to merge 1 commit into
mainfrom
fix/windows-bash-env-clarify
Draft

noogalabs wants to merge 1 commit into
mainfrom
fix/windows-bash-env-clarify

Conversation

@noogalabs

Copy link
Copy Markdown
Owner

What

Reframes the Windows section of install.mjs (step 6) from a WSL-required check to a bash-environment check.

Why

The block warned WSL (Windows Subsystem for Linux) is required and agents will not work without it on Windows. That is inaccurate: the proven native Windows path runs the agent shell scripts (bus/*.sh) under Git Bash, which ships with Git for Windows — and Git is already a hard requirement in step 2 (the installer fail()s without it and directs to git-scm.com / winget install Git.Git, both Git for Windows). So by step 6 the bash environment is already present. WSL is a genuine optional alternative, not a prerequisite.

This was field-confirmed: a Windows operator ran 6 agents 24h+ on PowerShell + Git Bash with zero WSL (error paths were /c/Users/... MSYS/Git-Bash format, not WSL's /mnt/c/).

Change

  • Section header WSL checkbash environment
  • commandExists('wsl') true → WSL detected — bash environment available
  • else branch → positive ok(...) confirming Git Bash provides the environment, with WSL presented as optional; removes the false warn('agents will not work without it')
  • drops the unused wslVersion variable

Scope / safety

  • Windows-only: the entire block is gated by if (IS_WINDOWS) — macOS/Linux paths untouched.
  • node --check install.mjs passes.
  • git diff --stat: install.mjs | 13 insertions(+), 18 deletions(-) — single file.

Draft pending review.

…t Bash, not WSL, is the default)

The Windows section warned "WSL required" and "agents will not work without it",
but the proven native path on Windows is Git Bash — which ships with Git for
Windows, already a hard requirement in step 2. WSL is an optional alternative,
not a prerequisite. Reword the check to confirm the bash environment via Git Bash
and present WSL as optional, removing the false "won't work without WSL" claim.

Windows-only: the entire block is gated by `if (IS_WINDOWS)`; macOS/Linux paths
are untouched.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Pase0Pr0p referenced this pull request in Pase0Pr0p/ascendops Jun 27, 2026
Stack API exposes a Bills resource (GET/POST/PATCH) with full AP fields
(vendor, due date, line items, approval status, GL account). Reporting
API v2 also exposes aged_payables_summary.json and bill_detail.json.

Add: Bill type, BillLineItem, AgedPayablesEntry, ListBillsOptions,
listBills()/getBill()/getAgedPayables() to AppFolioConnector interface,
createBill() write stub (Max-only, to confirm). Update implementation
order to include AP as step 6. Add open question #5 for AP write-gate
tier (not publicly documented — confirm at credential-gen).

Monitoring priority #4 (utility bills, vendor payments on time) is now
addressable once Rob's credentials land, regardless of Plus vs Max tier
(read path confirmed available on Plus+add-on).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant