Conversation
…ons (Windows) kb-ingest.sh, kb-query.sh, and kb-collections.sh hardcoded "$VENV_DIR/bin/python3" for the mmrag.py invocation. On Windows a Python venv puts the interpreter at Scripts/python.exe, not bin/python3, so all three KB operations failed on native Windows (Git Bash) — agents ran but KB ingest/query broke. Only kb-setup.sh had the Scripts/-vs-bin platform detect. Lift the same detect into the three scripts: resolve VENV_PY to Scripts/python on Windows (where the venv has Scripts/) or bin/python3 on Unix, then invoke "$VENV_PY". A deliberate single-resolve, not a `python3 || python` command fallback — these run real ingest/query operations, and a `||` fallback would re-execute the whole operation on a legitimate non-zero exit. Scope/safety: - Unix unchanged: on macOS/Linux `-d "$VENV_DIR/Scripts"` is false, so VENV_PY = bin/python3 — identical to prior behavior. - bash -n passes on all three. - Live Unix smoke: edited kb-collections.sh against the real framework venv lists all collections, exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Pase0Pr0p
referenced
this pull request
in Pase0Pr0p/ascendops
Jun 27, 2026
Stack API exposes a Bills resource (GET/POST/PATCH) with full AP fields (vendor, due date, line items, approval status, GL account). Reporting API v2 also exposes aged_payables_summary.json and bill_detail.json. Add: Bill type, BillLineItem, AgedPayablesEntry, ListBillsOptions, listBills()/getBill()/getAgedPayables() to AppFolioConnector interface, createBill() write stub (Max-only, to confirm). Update implementation order to include AP as step 6. Add open question #5 for AP write-gate tier (not publicly documented — confirm at credential-gen). Monitoring priority #4 (utility bills, vendor payments on time) is now addressable once Rob's credentials land, regardless of Plus vs Max tier (read path confirmed available on Plus+add-on). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
bus/kb-ingest.sh,bus/kb-query.sh, andbus/kb-collections.shhardcoded"$VENV_DIR/bin/python3"to invokemmrag.py. On Windows a Python venv places the interpreter atScripts/python.exe, notbin/python3, so all three KB operations failed on native Windows (Git Bash). Agents ran, but KB ingest/query/collections broke. Onlykb-setup.shhad theScripts/-vs-bin/platform detect.This is the bug a Windows operator reported on 2026-05-14 — it never landed.
Fix
Lift the same detect kb-setup.sh already uses into the three scripts: resolve
VENV_PYtoScripts/pythonon Windows (where the venv has aScripts/dir) orbin/python3on Unix, then invoke"$VENV_PY".Deliberately a single resolve, not a
python3 || pythoncommand fallback. kb-setup.sh can usecmd || cmdbecause it's an idempotent import-check. These scripts run real ingest/query operations — a||fallback would re-execute the entire operation on a legitimate non-zero exit (double POST / double query). Resolving the interpreter path once avoids that.Scope / safety
-d "$VENV_DIR/Scripts"is false, soVENV_PY = bin/python3— byte-identical behavior to before.bash -npasses on all three.kb-collections.sh, run against the real framework venv, listed all 7 collections, exit 0.Scripts/python.exe) is standard CPython.git diff --stat: 3 files, +27/-3.Draft pending review.