fix: keep imported auth profiles private - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing Codex or Claude credentials under the usual
022umask recreated credential files at0644and import directories at0755, including when replacing a previously private import. Runtimes that require private credential files then refused startup.Use explicit
0600credential/profile writes and0700auth/profile/import directories, repairing permissions on existing paths before writing new credentials. Preserve environment values, import metadata, other auth imports, and source files.Validation: six default-umask regression cases failed before the fix and pass afterward; deleting either file or directory permission repair makes the legacy-profile regression fail. All 3,538 tests, 12 runtime tests, 28 script tests, coverage thresholds, typecheck, CLI build, built-CLI import/replacement smoke, website build, and runtime dependency audit pass. Independent review found no in-scope defects.