Feature/unity unit tests

[norrietaylor]

No description provided.

[Copilot]

Pull request overview

Adds a fast “preflight” validation layer to catch common Unity/CI issues earlier, and wires it into the GitHub Actions pipeline (plus documents the workflow for contributors).

Changes:

• Added scripts/preflight.sh to perform Unity repo sanity checks without requiring Unity installed.
• Updated CI workflow to run preflight before EditMode tests and added an attempt at Docker image caching for the test job.
• Expanded CLAUDE.md with local testing + CI pipeline + preflight guidance and a pre-commit checklist.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
scripts/preflight.sh	New local/CI smoke-check script for Unity meta/GUID/size/import/asmdef/test-safety rules.
CLAUDE.md	Documentation updates describing test running, CI stages, preflight expectations, and contributor rules.
.github/workflows/unity-build.yml	Adds a preflight job before tests; introduces Docker image caching steps for the test job.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The “Branch & PR Conventions” and “Pre-Commit Checklist” sections are duplicated later in the file (the headings and checklists appear twice). Please remove the duplicate copy and keep a single checklist/conventions section to avoid conflicting updates over time.

[Copilot]

This check claims to validate “New folders (staged or untracked)”, but git diff --name-only --diff-filter=A HEAD will not include untracked files/folders. If you want to cover untracked additions too, incorporate git status --porcelain (or similar) and handle both staged and untracked paths; otherwise, adjust the comment/output to match the actual behavior.

Suggested change

	done < <(git diff --name-only --diff-filter=A HEAD 2>/dev/null | xargs -I{} dirname {} | sort -u | grep "^Unity/Assets")
	done < <({ git diff --name-only --diff-filter=A HEAD 2>/dev/null; git ls-files --others --exclude-standard 2>/dev/null; } | xargs -I{} dirname {} | sort -u | grep "^Unity/Assets")

[Copilot]

These checks rely on git diff ... HEAD to detect “new/changed” files. In CI the working tree is typically clean, so git diff HEAD is empty and the folder-meta/GUID-collision checks won’t run against PR changes. Consider diffing against the PR base (e.g., using GITHUB_BASE_REF / merge-base) or accepting a base ref/commit as an argument so the script can validate PR deltas in CI as well as local runs.

[Copilot]

The preflight job checks out with default depth and then runs scripts/preflight.sh, but the script’s “new/changed file” checks are driven by git diff against a base. To make CI preflight actually evaluate PR deltas, update this checkout to fetch enough history/refs (e.g., fetch-depth: 0 and/or fetch the PR base ref) and/or pass the base ref/commit to the script so it can diff against the PR base instead of relying on a clean working tree.

Suggested change

	uses: actions/checkout@v4
	uses: actions/checkout@v4
	with:
	fetch-depth: 0

[Copilot]

This document now contains duplicated sections (e.g., “Build & Test Commands” and the CI pipeline description appear here and then repeat again later in the file). This makes the guidance ambiguous and harder to maintain—please consolidate into a single canonical section and remove the duplicated block(s).

Suggested change

	There is no CLI build system. All building and testing happens through Unity Editor or CI.
	**Running tests locally:** Unity Editor → Window → General → Test Runner → EditMode tab
	Tests use Unity Test Framework (NUnit) at `Unity/Assets/Tests/EditMode/`. The test assembly (`TT2.Tests.EditMode`) uses namespace `TaekwondoTech.Tests.EditMode` and references `TT2.Runtime` (production code).
	**Preflight checks (run before every push):**
	```
	./scripts/preflight.sh
	```
	This catches most CI failures locally in ~1 second: missing `.meta` files, duplicate GUIDs, 500-line violations, bad namespace imports, missing asmdef package references, and unprotected `Object.Destroy()` in EditMode tests. **Always run this before pushing.** If you encounter a new class of CI failure not caught by preflight, add a check for it to the script so future runs catch it early.
	**CI pipeline** runs automatically on pushes to `main` and PRs (not forks). Three jobs in order:
	1. **Preflight** (~10s) — runs `scripts/preflight.sh`
	2. **EditMode Tests** (~3-4min) — `game-ci/unity-test-runner@v4` with `-nographics`
	3. **Builds** (~4min each) — WebGL, iOS, Android in parallel via `game-ci/unity-builder`
	For the authoritative details on local build/test workflow and the CI pipeline, see the **“Build, Test & CI pipeline”** section later in this document. That section is the single canonical source of truth and should be updated if the process changes.
	**Quick local workflow (summary only):**
	- Run EditMode tests via Unity Editor → Window → General → Test Runner → **EditMode** tab.
	- Always run the preflight script before pushing:
	```bash
	./scripts/preflight.sh

This catches most CI failures locally in about a second.

Refer to the later Build, Test & CI pipeline section for the full explanation of test locations, assemblies, and CI job configuration.