Skip to content

database: reduce API surface - #1418

Merged
yukibtc merged 2 commits into
masterfrom
database-api-surface
Aug 4, 2026
Merged

database: reduce API surface#1418
yukibtc merged 2 commits into
masterfrom
database-api-surface

Conversation

@yukibtc

@yukibtc yukibtc commented Aug 3, 2026

Copy link
Copy Markdown
Member

Notes to the reviewers

Should we use the BTreeSet<Event> instead of the Vec<Event> in the public APIs?

Checklist

  • I followed the contribution guidelines
  • I updated the relevant CHANGELOG.md (if applicable)
  • I understand and can explain all code in this PR

@codecov

codecov Bot commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.81818% with 21 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
database/nostr-ndb/src/lib.rs 0.00% 7 Missing ⚠️
database/nostr-database/src/error.rs 0.00% 5 Missing ⚠️
database/nostr-lmdb/src/lib.rs 33.33% 2 Missing ⚠️
database/nostr-memory/src/lib.rs 50.00% 2 Missing ⚠️
database/nostr-sqlite/src/store.rs 50.00% 2 Missing ⚠️
nostr-sdk/src/events_tracker.rs 60.00% 2 Missing ⚠️
nostr-sdk/src/local_relay/local/inner.rs 75.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@TheAwiteb

TheAwiteb commented Aug 3, 2026

Copy link
Copy Markdown
Member

Should we use the BTreeSet<Event> instead of the Vec<Event> in the public APIs?

Yes, it have some functions that would be helpful with the events, like union, is_disjoint and intersection

@yukibtc
yukibtc force-pushed the database-api-surface branch from 72cffac to 250cdfc Compare August 4, 2026 07:31
@yukibtc
yukibtc marked this pull request as ready for review August 4, 2026 07:32
@yukibtc
yukibtc requested a review from TheAwiteb as a code owner August 4, 2026 07:32
@yukibtc
yukibtc force-pushed the database-api-surface branch from 250cdfc to c94ba9d Compare August 4, 2026 07:35
@yukibtc
yukibtc marked this pull request as draft August 4, 2026 08:18
@yukibtc
yukibtc force-pushed the database-api-surface branch from c94ba9d to 3cf37ee Compare August 4, 2026 10:13
@yukibtc
yukibtc marked this pull request as ready for review August 4, 2026 10:13
@yukibtc
yukibtc force-pushed the database-api-surface branch from 3cf37ee to 5ffa4b8 Compare August 4, 2026 10:31
TheAwiteb
TheAwiteb reviewed Aug 4, 2026
View reviewed changes
Comment thread nostr-sdk/src/client/api/fetch_events.rs Outdated
@yukibtc
yukibtc force-pushed the database-api-surface branch from 5ffa4b8 to 2900448 Compare August 4, 2026 10:45
TheAwiteb
TheAwiteb reviewed Aug 4, 2026
View reviewed changes
Comment thread nostr-sdk/src/local_relay/local/inner.rs Outdated
TheAwiteb
TheAwiteb reviewed Aug 4, 2026
View reviewed changes
Comment thread nostr-sdk/src/relay/api/fetch_events.rs Outdated
TheAwiteb
TheAwiteb approved these changes Aug 4, 2026
View reviewed changes

@TheAwiteb TheAwiteb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

yukibtc added 2 commits August 4, 2026 12:57
@yukibtc
database: add Error::io helper
6e7530a 
Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
@yukibtc
database: reduce API surface
180d1e6 
- Remove `Events` and `Profile` structs
- Remove `NostrDatabaseExt` trait

Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
@yukibtc
yukibtc force-pushed the database-api-surface branch from 2900448 to 180d1e6 Compare August 4, 2026 11:00
@yukibtc
yukibtc merged commit 180d1e6 into master Aug 4, 2026
42 checks passed
@yukibtc
yukibtc deleted the database-api-surface branch August 4, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheAwiteb TheAwiteb TheAwiteb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yukibtc @TheAwiteb