Skip to content

Update NostrConnectMessage display and logs #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yukibtc merged 2 commits into from
Aug 7, 2026
Merged

Update NostrConnectMessage display and logs #1432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba0781f
nostr: update `Display` implementation for `NostrConnectMessage` to u…
yukibtc Aug 7, 2026
b3ababb
connect: log parsed `NostrConnectMessage` to redact sensitive data
yukibtc Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions nostr/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@

-->

## Unreleased

### Fixed

- The `Display` implementations of `NostrConnectMessage` redact the sensitive data (https://github.com/nostrdevkit/nostr/pull/1432)

## v0.45.0 - 2026/08/05

### Breaking changes
Expand Down
3 changes: 2 additions & 1 deletion nostr/src/nips/nip46.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,8 +656,9 @@ impl fmt::Debug for NostrConnectMessage {
}

impl fmt::Display for NostrConnectMessage {
#[inline]
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(f, "{}", self.as_json())
fmt::Debug::fmt(self, f)
}
}

Expand Down
6 changes: 6 additions & 0 deletions signer/nostr-connect/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@

-->

## Unreleased

### Fixed

- Log the parsed `NostrConnectMessage` to redact sensitive data, instead of the raw decrypted message (https://github.com/nostrdevkit/nostr/pull/1432)

## v0.45.0 - 2026/08/05

### Breaking changes
Expand Down
5 changes: 3 additions & 2 deletions signer/nostr-connect/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,14 +409,15 @@ async fn get_remote_signer_public_key(
Err(_) => continue,
};

tracing::debug!("Received Nostr Connect message: '{msg}'");

// Parse message
let msg: NostrConnectMessage = match NostrConnectMessage::from_json(msg) {
Ok(m) => m,
Err(_) => continue,
};

// The Debug and Display implementations of NostrConnectMessage redact the sensitive data.
tracing::debug!("Received Nostr Connect message: '{msg}'");

// Check if it's a `connect` response.
//
// Per NIP-46, for nostrconnect:// (client-initiated) connections the signer
Expand Down
Loading