Skip to content

nostr: use zeroize for ECDH key handling in NIP-44 and NIP-04 - #1435

Merged
yukibtc merged 2 commits into
masterfrom
ecdh-shared-key
Aug 7, 2026
Merged

nostr: use zeroize for ECDH key handling in NIP-44 and NIP-04#1435
yukibtc merged 2 commits into
masterfrom
ecdh-shared-key

Conversation

@yukibtc

@yukibtc yukibtc commented Aug 7, 2026

Copy link
Copy Markdown
Member

Description

Closes #1431

Checklist

  • I followed the contribution guidelines
  • I updated the relevant CHANGELOG.md (if applicable)
  • I understand and can explain all code in this PR

Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
@yukibtc
yukibtc marked this pull request as ready for review August 7, 2026 09:52
@yukibtc
yukibtc requested a review from TheAwiteb as a code owner August 7, 2026 09:52
Closes #1431

Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
@yukibtc

yukibtc commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

@Datawav

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@TheAwiteb TheAwiteb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@yukibtc
yukibtc merged commit 41b0364 into master Aug 7, 2026
43 checks passed
@yukibtc
yukibtc deleted the ecdh-shared-key branch August 7, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NIP-04/NIP-44 ECDH shared key and shared point not zeroized after use

2 participants