Skip to content

nostr: require CryptoRng for secret key generation - #1437

Merged
yukibtc merged 1 commit into
masterfrom
nostr-rngs
Aug 7, 2026
Merged

nostr: require CryptoRng for secret key generation#1437
yukibtc merged 1 commit into
masterfrom
nostr-rngs

Conversation

@yukibtc

@yukibtc yukibtc commented Aug 7, 2026

Copy link
Copy Markdown
Member

Description

Closes #1429

Checklist

  • I followed the contribution guidelines
  • I updated the relevant CHANGELOG.md (if applicable)
  • I understand and can explain all code in this PR

@yukibtc
yukibtc requested a review from TheAwiteb as a code owner August 7, 2026 10:03
Closes #1429

Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
@yukibtc

yukibtc commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

@Datawav

@TheAwiteb TheAwiteb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@yukibtc
yukibtc merged commit 240f6fc into master Aug 7, 2026
43 checks passed
@yukibtc
yukibtc deleted the nostr-rngs branch August 7, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Secret-key generation accepts non-cryptographic RNGs (missing CryptoRng bound)

2 participants