Merged
Conversation
Added new Output Type URL
not-lain
approved these changes
Jul 22, 2025
Owner
not-lain
left a comment
not-lain
left a comment
There was a problem hiding this comment.
LGTM, Thanks a lot for working on this 🙌
Comment on lines
+80
to
+85
| with BytesIO() as buffer: | ||
| img_format = img.format or "PNG" | ||
| img.save(buffer, format=img_format) | ||
| buffer.seek(0) | ||
|
|
||
| file_name = original_name or f"{uuid.uuid4()}.{img_format.lower()}" |
Owner
There was a problem hiding this comment.
this section is very similar to the base64 implementation, do you think we should implement the DRY principle here or we should leave it like this for easier access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new Output Type URL