feat: v1.4.1 — one-liner installer (opt-in, SHA-pinned)#3
Merged
notabotchef merged 1 commit intomainfrom Apr 12, 2026
Merged
Conversation
Opt-in installer script with security-first design: - install.sh: full arg parser (--dry-run, --yes, --path, --mode, --verbose), security warning + script SHA256 display, 5-second countdown for piped-from- curl safety, A0 dir auto-detection (filesystem + docker inspect candidates), ambiguous detection exits 2 under --yes, docker mode (SHA-verified override download) + manual mode (git clone/pull + execute.py), idempotent re-run check, post-install bridge_doctor verification, shellcheck clean (0 errors) - .github/workflows/release.yml: on v* tag, computes install.sh SHA256, attaches to GitHub Release notes; publishes install.sh + override.yml as release assets for user verification - README: "Install via script" section added between Quick Start and Manual Install with explicit security warning block; both curl forms shown; SHA verification instructions; v1.4.1 changelog - plugin.yaml: version 1.4.1 Verification: bash install.sh --dry-run --yes exits 0 (no filesystem changes); --path=/tmp/doesnotexist exits 2; shellcheck reports 0 errors Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
Author
|
SHA verification on the override file is a nice touch. The 5-second countdown for piped-from-curl is good UX — gives people a chance to ctrl-c if they didn't mean to run it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 3 of setup-friction-fix: opt-in one-liner installer for users who want a single command. Quick Start (v1.4.0) remains the default and recommended path.
install.sh— full arg parser (--dry-run,--yes,--path,--mode=docker|manual,--verbose). 5-second countdown + Y/n confirm when not piped with--yes. NO_COLOR-aware. Idempotent — skips if already installed at the same version.docker inspect. BLOCKs ambiguously on multiple matches under--yes._download_and_verify_overridechecks the override file SHA against a pinned value baked into the script per release. SHA mismatch → exit 3, file removed. Pinned SHA published in GitHub Release notes per tag.--mode=docker(default: download override, verify SHA, restart compose) and--mode=manual(git clone/pull +docker exec execute.py).bridge_doctor --quietin the container. On failure, falls through to verbose output and links the Troubleshooting README section..github/workflows/release.yml— onv*tag, computesinstall.shSHA256 and attaches it to the GitHub Release notes. Publishesinstall.sh+docker-compose.override.ymlas release assets.Polish (over autopilot phase commit)
--helpnow usesawkto skip the shebang and stop at the first non-comment line. macOS-compatible (no GNU sed\?extension).(cd <dir> && docker compose up -d)when adocker-compose.ymlis found, instead of an||fallback chain that ate stderr from the first attempt.Why
Some users want curl-pipe-bash. Some users (correctly) refuse to. This PR ships the convenience without forcing it: Quick Start is documented first, the script is opt-in with explicit security warnings, and SHA pinning gives auditors a verifiable handshake.
Test plan
bash -n install.sh— cleanshellcheck install.sh— 0 errorsbash install.sh --dry-run --yes— exit 0, no filesystem changesbash install.sh --path=/tmp/doesnotexist— exit 2, clear errorbash install.sh --help— prints clean help (no shebang, no leading#)python -m pytest tests/test_probe_novnc.py— 7/7 pass (no regression)v1.4.1tag triggersrelease.ymland pins the SHA into the release notesFiles
install.sh— 443 lines, opt-in installer.github/workflows/release.yml— SHA-pinned release notesREADME.md— "Install via script" sectionplugin.yaml— version 1.4.1Phase 3 of 3 in
.rune/plan-setup-friction-fix.md. Depends on #1 (v1.3.0) and #2 (v1.4.0).