PYMIDI updates - #1
Open
triplef wants to merge 8 commits into
Open
Conversation
Added error message when MIDIClientCreate() fails.
…shorter than deviceName. We need to pass length of first string to compare entire string, see CFStringCompareWithOptions() documentation.
Note that this change will remove a trailing space from the endpoint name in the case where endpointName is an empty string and deviceName is nil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a couple of small changes to PYMIDI – just wanted to let you know in case you want to pull them into your version.
Thanks!
P.S. and a heads up in case you don’t know yet: your website http://notahat.com/pymidi still links to the nonexistent Subversion repository.