Fix: On Windows, Unix slashes of watched paths normalize to Windows slashes.#721
Open
boenrobot wants to merge 4 commits intonotify-rs:mainfrom
Open
Fix: On Windows, Unix slashes of watched paths normalize to Windows slashes.#721boenrobot wants to merge 4 commits intonotify-rs:mainfrom
boenrobot wants to merge 4 commits intonotify-rs:mainfrom
Conversation
boenrobot
force-pushed
the
allYourSlashesAreNormalizeToUs
branch
from
5facb62 to
b80f46c
Compare
boenrobot
changed the title
riberk
reviewed
Oct 21, 2025
…nly the caconicalize() call. As part of that, trying to watch non existent files or folders will now result in Error:io rather than Error:generic. Refactor the test_mixed_slashes_are_normalized() to use mpsc for event storage.
…urSlashesAreNormalizeToUs # Conflicts: # notify/src/windows.rs
Member
|
@boenrobot Could you take a look and fix the tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #687