feat: add MCP tool annotations for human-in-the-loop safety#4
Merged
Conversation
All 54 tools now declare their intent via MCP protocol annotations: - 51 read-only tools: ReadOnlyHint=true (clients may auto-approve) - 3 destructive tools: DestructiveHint=true (clients prompt user) This enables MCP clients (Claude Code, Cursor) to enforce confirmation dialogs before executing server actions or credential mutations, even when MCP_READ_ONLY=false allows the tools to be registered. Also updates README Security section to document the three-layer safety architecture: read-only mode + tool annotations + credential isolation.
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReadOnlyHint=true— clients may auto-approveDestructiveHint=true— clients prompt for confirmationWhy
When
MCP_READ_ONLY=falseenables destructive tools, the MCP client (Claude Code, Cursor) will still enforce a human confirmation dialog before executing. The server declares, the client enforces.Test plan
make build-all— compiles cleanlygo test ./...— all tests passmake run-golangci-lint— 0 issues