security: pre-release hardening#7
Merged
Merged
Conversation
CRITICAL: - Nova getServerHandler: switch to field allowlist (AdminPass was leaking via full struct serialization) HIGH: - SSE transport: bind 127.0.0.1 by default (was 0.0.0.0 with no auth) - URL path injection: add UUID validation for all ID params in URL paths (archer, keppel, limes) - Query param injection: use SafeQueryParams with url.QueryEscape instead of raw string concatenation - Sanitizer: add "adminPass" and "admin_pass" to sensitive keys list MEDIUM: - Token race: use mutex-protected Token() accessor instead of direct .TokenID field access Also: - Add root LICENSE file (GitHub detection) - Add SECURITY.md (vulnerability reporting) - Fix README tool names (6 were wrong) - Add companion toolkit link to README - Add security validation tests (UUID, path segment, query encoding, adminPass redaction)
Merging this branch changes the coverage (2 decrease, 3 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive security hardening before public release. Addresses findings from security audit of credential handling, input validation, and response sanitization.
Critical
getServerHandlerwas marshalling the entire gophercloudServerstruct, which includesAdminPass. Switched to explicit field allowlist (same pattern as ironic.go)High
0.0.0.0to127.0.0.1(SSE has no auth — network binding was dangerous)../../admin/tokensstyle attacksSafeQueryParams()using properurl.QueryEscape()(archer, keppel, limes)adminPassandadmin_passto sensitive keys as defense-in-depthMedium
provider.Token()now uses gophercloud's mutex-protectedToken()method instead of direct.TokenIDfield accessRelease readiness
LICENSEfile (GitHub license detection)SECURITY.md(vulnerability reporting policy)Tests
Test plan
make build-allpassesgo test ./...— all tests pass (including new security tests)make run-golangci-lint— 0 issuesreuse lint— compliant&,=, spaces