fix: accept non-hyphenated UUIDs and correct install instructions#9
Merged
Conversation
OpenStack Keystone returns project/domain IDs as 32-char hex strings without hyphens (e.g., "2bac466eed364d8a92e477459e908736"). Our UUID validator only accepted the hyphenated format, causing Limes and other tools that take domain_id/project_id to reject valid OpenStack IDs. Also updates README configuration section: Claude Code reads MCP server config from ~/.claude.json (via `claude mcp add`), not from ~/.claude/settings.json which doesn't support mcpServers.
The -? approach allowed mixed-hyphenation (e.g., "550e8400-e29b41d4...") which would pass validation but confuse users with 404s from OpenStack. Now uses alternation: either fully hyphenated (8-4-4-4-12) OR fully non-hyphenated (32 hex chars). Adds negative test cases for partial hyphenation to document this as explicitly rejected.
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2bac466eed364d8a92e477459e908736). Our validator only accepted the8-4-4-4-12format, causing Limesdomain_id/project_idparams to be rejected. Regex now uses-?to make hyphens optional while preserving hex-only security.~/.claude/settings.json(which Claude Code doesn't read for MCP) toclaude mcp addCLI command. Added separate section for Cursor/other MCP clients.Test plan
go test ./...passeslimes_get_project_quotasucceeds with non-hyphenated domain/project IDs from Keystone