feat(refs): base-instructions — communication anti-patterns, scope management (Level 0→3)#632
Open
notque wants to merge 1 commit into
Open
feat(refs): base-instructions — communication anti-patterns, scope management (Level 0→3)#632notque wants to merge 1 commit into
notque wants to merge 1 commit into
Conversation
…nagement (Level 0→3) Adds two Level-3 reference files to agents/base-instructions: - communication-anti-patterns.md: grep-detectable prohibited phrases with bad/good prose pairs (self-congratulation, hedging, narration, trailing validation requests). 232 lines, 90 concrete hits, zero generic advice. - scope-management.md: over-engineering anti-patterns with rg/grep detection commands — premature abstraction, impossible nil guards, compat shims, feature flags, unrequested tests. 263 lines, 99 concrete hits. Updates agents/base-instructions.md with a loading table mapping task signals (verbose output, scope creep, diff review) to the two new files. Audit result: Level 0 → Level 3 (Deep).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Enrichment: base-instructions
Summary
Enriches
agents/base-instructionsfrom Level 0 (no references) to Level 3 (deep).Targets Processed
base-instructionsNew Reference Files
agents/base-instructions/references/communication-anti-patterns.md(232 lines)Concrete prohibited phrase table, grep-detectable anti-pattern catalog (self-congratulation, narration openers, hedged outcomes, trailing validation requests, capability framing), error-fix mappings, and correct prose pattern examples.
agents/base-instructions/references/scope-management.md(263 lines)Over-engineering signal table, grep/rg detection commands for premature abstraction, impossible nil guards, compat shims, feature flags, and unrequested test additions. Includes a scope verification checklist using
git diff.Loading Table
Added to
agents/base-instructions.md— maps task signals to reference files:communication-anti-patterns.mdscope-management.mdscope-management.mdAudit Result
Validation Gate
[KEEP] base-instructions: Loading table correctly routes all 3 test signal types; both files contain grep-detectable patterns with bad/good code pairs — not generic advice.
Generated by reference-enrichment headless process (ADR-173) — Run ID: 2026-05-10-0407