fix: positive-frame all references for 100% joy-check compliance#635
Merged
Conversation
… compliance Fleet-wide sweep: 56 violations → 0 across 45 files. Mechanical fixes (22): Anti-Pattern headings → Common Failure Modes via expanded bulk_fix_instruction_joy.py SAFE_REWRITES dictionary. Editorial fixes (28): NEVER/Don't/Avoid/do NOT → positive action framing. Each rewrite preserves technical substance, changes only framing direction. Template fixes (high-severity violation generators): - agent-template.md: "Don't add features" → "Scope changes to what was requested" - preferred-patterns.md: NEVER/Do NOT in instructional prose → positive framing - skill-template.md: NEVER example in teaching table → positive alternative Infrastructure: - PHILOSOPHY.md added to validator allowlist (teaches patterns by example) - bulk_fix_instruction_joy.py: 6 → 28 safe rewrite entries - test expectations updated for new rewrite values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Anti-Patternheadings →Common Failure Modesvia expandedbulk_fix_instruction_joy.pyNEVER/Don't/Avoid/do NOT→ positive action framing, substance preservedPHILOSOPHY.mdadded to validator allowlist (teaches patterns by example, not instructions)Test plan
python3 scripts/validate_positive_instruction_docs.pyreturnscount: 0pytest scripts/tests/test_joy_check_instruction_mode.py— 179 tests passpytest scripts/tests/test_bulk_fix_instruction_joy.py— 3 tests pass