fix: zero-allowlist joy-check — every .md file passes#637
Merged
Conversation
Validator rewritten: scans all git-tracked .md files via git ls-files. Allowlist removed entirely — only .py scripts are exempt (they aren't scanned since the tool only processes .md). 78 violations fixed across 28 files: - shared-patterns: NEVER/FORBIDDEN → positive actions (keep .gitignore intact, resolve blockers through gates, report severity honestly) - sapcc-conventions: Go project rules reframed positively (reserve must.Return for startup, use explicit error handling in handlers) - PHILOSOPHY.md + instruction-rubric.md: teaching tables wrapped in fenced blocks so scanner skips quoted negative examples - dream-prompt, enrichment/decomposition prompts, html-builder: all "Do NOT" instructions reframed as "Do Y instead" - forbidden-patterns-template → hard-gate-patterns-template Every rewrite says what to do, not what to avoid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.mdfile must pass joy-checkgit ls-filesto find targets (excludes gitignored files automatically)Test plan
python3 scripts/validate_positive_instruction_docs.pyreturnscount: 0pytest scripts/tests/— 2,253 pass