support for Drunix deployment in falcon - #43
Conversation
feat: add Yugabyte deployment support
feat: add keydb deployment support
| nameOverride: "" | ||
| fullnameOverride: "" | ||
|
|
||
| imageRepository: eqalpha/keydb |
There was a problem hiding this comment.
This image is older and not maintained for longer time, temporarily we can use bitnamilegacy/keydb:latest, long term we need to plan on maintaining at our side.
| nodes: 3 | ||
|
|
||
| password: "" | ||
| existingSecret: "" |
There was a problem hiding this comment.
Create secure password with openssl as part of setup, create and map the secret as reference
| ## When certManager.enabled=true and boostrapSelfsigned=true, rootCA is ignored. | ||
| ## When certManager.enabled=true and bootstrapSelfsigned=false, only rootCA.cert is used | ||
| ## to verify TLS certs generated and signed by the external provider. | ||
| rootCA: |
There was a problem hiding this comment.
Load all CA from reference to secret. Should be able to generate while setting up, than a hard coded value.
|
Sure @tittuvarghese , we will incorporate the necessary changes. |
| {{- end }} | ||
| {{- if .Values.tls.enabled }} | ||
| - name: SSL_CERTFILE | ||
| value: "/root/.yugabytedb/root.crt" |
There was a problem hiding this comment.
Support override with default.
| mountPath: "/home/yugabyte/bin/setup-credentials" | ||
| {{- if .Values.tls.enabled }} | ||
| - name: yugabyte-tls-client-cert | ||
| mountPath: "/root/.yugabytedb/" |
There was a problem hiding this comment.
Support override with default
Added PR review changes for keydb
Added PR reviews changes for yugabyte
|
@Morviss Could you clarify the ownership of these newly added charts? Are they original implementations, or are they forks/copies from an upstream repository? If they are being included solely due to downstream deployment dependencies, we should avoid checking external code into this repository unless we intend to actively maintain it. Instead, we should document these as dependencies in the deployment section, referencing the upstream Helm repository URL and providing a sample Falcon is designed to be an independent tool with custom charts tailored specifically for its use case. We should avoid introducing external chart dependencies into our core codebase. |
4 participants
Updted the yugabyte and created new PR with the integration branch