Skip to content

Conversation

@roji
Copy link
Member

@roji roji commented Dec 25, 2025

To restrict all permissions by default (CodeQL warning)

Copilot AI review requested due to automatic review settings December 25, 2025 08:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds empty permissions: blocks to GitHub Actions workflow files to restrict default permissions and address a CodeQL security warning. While the security intent is correct, the implementation has issues that could break workflow functionality.

Key Changes:

  • Added empty permissions: blocks to two workflow configuration files
  • Applied at the workflow level to restrict all default permissions

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/trigger-doc-build.yml Adds empty permissions block to documentation build trigger workflow
.github/workflows/build.yml Adds empty permissions block to main build, test, and release workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@roji roji enabled auto-merge (squash) December 25, 2025 09:06
To restrict all permissions by default (CodeQL warning)
@roji roji merged commit 4356b43 into npgsql:main Dec 25, 2025
10 checks passed
@roji roji deleted the Permissions branch December 25, 2025 09:25
roji added a commit that referenced this pull request Dec 25, 2025
To restrict all permissions by default (CodeQL warning)

(cherry picked from commit 4356b43)
roji added a commit that referenced this pull request Dec 25, 2025
To restrict all permissions by default (CodeQL warning)

(cherry picked from commit 4356b43)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant