refactor: use interest invokers for contributor hovercard#1985
Draft
knowler wants to merge 7 commits intouserquin/feat-add-contributors-popup-cardfrom
Draft
refactor: use interest invokers for contributor hovercard#1985knowler wants to merge 7 commits intouserquin/feat-add-contributors-popup-cardfrom
knowler wants to merge 7 commits intouserquin/feat-add-contributors-popup-cardfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
e6de0b3 to
d9c61ce
Compare
TODO: will add the v-if/v-else back with the link fallback
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring #1596 to use interest invokers, the Popover API, and anchor positioning instead. This is partly an experiment, so don’t let this block you from iterating on your PR @userquin.
Using these web platform APIs means we don’t need to add a whole lot of complexity to pull this off. The only JS we need is to update the
activeContributorusing thebeforetoggleevent for the popover.This only works in Chromium, so we have a couple of options:
Anchor positioning is only Baseline Newly Available as of December, but it does already have 81% availability in browsers globally.
I personally don’t think it’s worth it to try and create behavioural parity across all of our browser targets here. The content is likely available if the user just clicks through the GitHub links. The only thing that is missing is the governance roles, which might might be able to find a solution (grouping under separate headings would be the most easily accessible, especially from an information architecture perspective).
TODO