Skip to content

fix: adjust logo sizing on about page#1986

Open
vladh wants to merge 3 commits intonpmx-dev:mainfrom
vladh:main
Open

fix: adjust logo sizing on about page#1986
vladh wants to merge 3 commits intonpmx-dev:mainfrom
vladh:main

Conversation

@vladh
Copy link
Contributor

@vladh vladh commented Mar 7, 2026

🔗 Linked issue

N/A

🧭 Context

Currently, the logo grid on the about page has some issues.

First, the hover background is uneven, and in some parts is close to colliding with the logos. In particular, look at the lack of horizontal spacing on the Vercel logo, and the general lack of spacing on the Open Source Pledge logo.

Screenshots Screen Shot 2026-03-07 at 22 45 47
Secondly, some logos are much bigger than others, which makes them look out of place, and also makes the whole grid more irregular. Look at the Nuxt and Vue.js logos, and how big they are relative to the logos above and below them.
Screenshots 2026-03-07-22-47-25
### 📚 Description

I added more padding to all of the logos.

I replaced the previous per-logo padding-block adjustment with a more reliable per-logo max-height adjustment. This makes it easier to make the logos look consistent with each other.

I added a negative horizontal margin to the logo container, so that logos are flush with the left and right edges.

I generally adjusted all dimensions to make the logos look better.

cc @alexdln 🙏🏻

Before and after, no hover

Before

Screen Shot 2026-03-07 at 22 43 20

After

Screen Shot 2026-03-07 at 22 43 24
Before and after, with hover background (all hover effects enabled for illustration)

Before

Screen Shot 2026-03-07 at 22 45 47

After

Screen Shot 2026-03-07 at 22 45 52
Before and after on mobile

Before

Screen Shot 2026-03-07 at 22 46 53

After

Screen Shot 2026-03-07 at 22 46 56

@vercel
Copy link

vercel bot commented Mar 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Mar 7, 2026 11:37pm
npmx.dev (canary) Ready Ready Preview, Comment Mar 7, 2026 11:37pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Mar 7, 2026 11:37pm

Request Review

@codecov
Copy link

codecov bot commented Mar 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@vladh
Copy link
Contributor Author

vladh commented Mar 7, 2026

Test failures seem unrelated.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 7, 2026

📝 Walkthrough

Walkthrough

This pull request modifies logo configuration across three files to standardise sizing constraints. The OSS_PARTNERS array receives new maxHeight properties for Nuxt, Vue, and Vue Data UI entries. The SPONSORS array replaces the normalisingIndent field with maxHeight for Vercel, Void Zero, vlt, and Bluesky entries, whilst removing normalisingIndent from Netlify entirely. The LogoList component's BaseItem type signature is updated to use maxHeight instead of normalisingIndent, with corresponding style bindings and layout adjustments to padding and height values.

Possibly related PRs

Suggested reviewers

  • alexdln
  • danielroe
  • serhalp
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly addresses the changeset by explaining the motivation (uneven hover background and inconsistent logo sizing) and detailing the solutions implemented (maxHeight adjustments, padding increases, negative margins).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@alexdln
Copy link
Member

alexdln commented Mar 8, 2026

They had fixed sizes specifically for consistency in effects. When one element has a hover height of 60px, and the next one has a hover height of 40px, it looks like a bug (and is a bit inconvenient for navigation).

To compensate for this alignment, normalizingIndent was added to the logo settings.

The voidzero group is a special case, since this appearance and such indentations are a strict correspondence to how this group was styled by the authors of the project

Maybe we should make the vertical height bigger for all items (equal for each, but bigger, f.e. not h-11 but h-15), but about the other edits - it seems to me that this is trading one problem for another

P.S. A few tips: create new branches instead of working in main - this will make future support easier for both you and the maintainers. Also, use details for long screenshots (click edit on the comment to see how it works)

@vladh
Copy link
Contributor Author

vladh commented Mar 8, 2026

When one element has a hover height of 60px, and the next one has a hover height of 40px, it looks like a bug (and is a bit inconvenient for navigation).

Okay! I'll leave this up to your judgement. For me, it's much more important for each logo to look good together with its hover background, since, when hovering, they are both visible at the same time. It's the near-collision between the logo and the edge of the hover background that jumps out as a bug to me personally.

It's true that my change makes the hover background of the different logos differently sized, but in my opinion this is more difficult to notice, because no two hover backgrounds are visible at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants