Skip to content

fix: code line highlighting not working with the light theme#2015

Merged
ghostdevv merged 1 commit intonpmx-dev:mainfrom
RYGRIT:fix/light-theme-code-highlight
Mar 10, 2026
Merged

fix: code line highlighting not working with the light theme#2015
ghostdevv merged 1 commit intonpmx-dev:mainfrom
RYGRIT:fix/light-theme-code-highlight

Conversation

@RYGRIT
Copy link
Contributor

@RYGRIT RYGRIT commented Mar 10, 2026

🔗 Linked issue

🧭 Context

📚 Description

  • before
image
  • after
image

@vercel
Copy link

vercel bot commented Mar 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 10, 2026 1:31am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 10, 2026 1:31am
npmx-lunaria Ignored Ignored Mar 10, 2026 1:31am

Request Review

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7f3904d3-cdf1-4565-bde7-43c80db215f6

📥 Commits

Reviewing files that changed from the base of the PR and between 8cea27f and 0d5db0b.

📒 Files selected for processing (1)
  • app/assets/main.css

📝 Walkthrough

Walkthrough

The Shiki theme styling rules in the CSS file have been restructured. The previous approach applied font-related properties alongside color and background to both parent and child selectors. The updated structure separates these concerns: colour and background properties are now applied directly to the parent element (.shiki), whilst font-related properties such as font-style, font-weight, and text-decoration have been moved to an inner nested span selector using a child combinator. This reorganisation affects 8 lines added and 5 lines removed in total.

Suggested reviewers

  • danielroe
  • ghostdevv
🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The pull request description consists only of template placeholders and before/after images with no actual textual explanation of the changes. Add a meaningful description explaining why the CSS restructuring was necessary and how it fixes the code line highlighting issue in the light theme.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ghostdevv ghostdevv added the front Frontend, Design label Mar 10, 2026
@ghostdevv ghostdevv changed the title fix: fixed code line highlighting being overridden in light theme fix: code line highlighting not working with the light theme Mar 10, 2026
@ghostdevv ghostdevv added this pull request to the merge queue Mar 10, 2026
Merged via the queue into npmx-dev:main with commit 11842b4 Mar 10, 2026
21 checks passed
@RYGRIT RYGRIT deleted the fix/light-theme-code-highlight branch March 10, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

front Frontend, Design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants