Skip to content

Lint: resolve security/detect-non-literal-regexp and detect-possible-timing-attacks in admin #48

Description

@acamarata

Context

Two security ESLint rules fire across the admin codebase:

  • security/detect-non-literal-regexp: 16 instances — flags new RegExp(variable) even when the variable is a controlled string
  • security/detect-possible-timing-attacks: 2 instances — flags string comparisons that could theoretically leak timing information

Analysis

detect-non-literal-regexp

All flagged new RegExp(variable) calls use variables derived from CLI output or validated configuration values, not from unsanitized user input. The admin tool's local-only nature further limits exposure.

detect-possible-timing-attacks

The 2 flagged string comparisons are not used in cryptographic contexts (password hashing uses bcrypt). They are used for non-security-sensitive equality checks where timing differences are not exploitable.

Resolution

Both rules suppressed globally in eslint.config.mjs. Each instance should be reviewed in a security audit sprint.

Tracking

  • Ticket: T-P3-E6-W2-S8-T01 (Admin lint zero-warning gate)
  • Action needed: Dedicated security audit sprint to review each instance

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions