fix(ci): quarterly-doc-audit hardening — lfs filter disable + drop unmatched mdx pathspec - #214
Merged
Merged
Conversation
… + drop unmatched mdx pathspec Consistent with the same investigation/fix applied to admin/web/plugins: 1. Disable git-lfs filters right after Checkout (defensive; cli currently has one candidate LFS-filtered file — vendor/.../chroma.jpg — that doesn't presently trip this, but keeps this repo consistent with the others in case that changes). 2. Drop the unmatched **/*.mdx pathspec from add-paths — this repo has zero .mdx files (confirmed via a full-tree grep), so any run where the audit actually finds+fixes .md issues would hit the same 'pathspec did not match any files' fatal error that broke plugins' Open-auto-fix-PR step (see plugins #31). Currently latent here since cli's last audit run was clean (no .md changes to stage), but the bug is real and would trip the moment findings appear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of a consistency fix across the 5 repos sharing this workflow (cli/admin/web/plugins/ntask), following the tarball-extraction fix (#213) and the plugins mdx-pathspec bug (nself-org/plugins#31):
**/*.mdxfromadd-paths: this repo has zero.mdxfiles.git add's multi-pathspec matching is atomic — an unmatched pathspec element aborts the entiregit add, which broke plugins'Open auto-fix PRstep whenever the audit actually produced.mdchanges to stage. Currently latent here (cli's last audit run was clean), but the bug is real..gitattributes-declaredfilter=lfsbinaries that were never actually migrated to real LFS pointers show as perpetually "modified" to git, breakingpeter-evans/create-pull-request's internal stash/checkout dance. cli has one candidate file (vendor/.../chroma.jpg) that doesn't presently trip this, but this keeps the workflow consistent across all 5 repos.Test plan
.mdxfiles.git lfs uninstall --localis a documented, safe no-op when nothing is affected.Quarterly doc auditstays green on main HEAD after merge.