nginx: drop stale LazyResolve comment in nginx.conf.tmpl - #373
Merged
Merged
Conversation
acamarata
force-pushed
the
fix-nginx-tmpl-lazyresolve-comment
branch
from
September 4, 2026 03:47
0a83a00 to
db41697
Compare
template comment still described the old opt-in behaviour.
acamarata
force-pushed
the
fix-nginx-tmpl-lazyresolve-comment
branch
from
September 4, 2026 03:47
db41697 to
15f9655
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only. #364 removed
LazyResolveand the staticupstream {}branch;nginx.conf.tmplstill described the old opt-in behaviour. Replaced with what the generator actually does now (request-timeset $up_x; proxy_pass $up_xwith the resolver). No generated output changes; template tests unaffected.