Skip to content

chore(ci): bump the actions group across 1 directory with 2 updates - #157

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/github_actions/actions-790f3d4e60
Closed

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/github_actions/actions-790f3d4e60

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 27, 2026

Copy link
Copy Markdown
Contributor

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


Bumps the actions group with 2 updates in the / directory: actions/setup-java and trufflesecurity/trufflehog.

Updates actions/setup-java from 5 to 6

Release notes

Sourced from actions/setup-java's releases.

v6.0.0

What's Changed

... (truncated)

Commits

Updates trufflesecurity/trufflehog from 3.97.0 to 3.97.1

Release notes

Sourced from trufflesecurity/trufflehog's releases.

v3.97.1

What's Changed

New Contributors

Full Changelog: trufflesecurity/trufflehog@v3.97.0...v3.97.1

Commits
  • 20652fb Carry GitHub App installation ID on repo units (#5215)
  • 3ab759f Refine SECURITY.md (#5216)
  • 2cdb97d [SCAN-101] s3 source accept persisted unit envelopes in UnmarshalSourceUnit (...
  • 4ec7749 preallocate bindings capacity in dockerhub and groq, with unit tests (#5213)
  • 9610306 Doubled timeout, as MongoDB secrets are repeatedly hitting this and failing t...
  • 9d3f5d1 [SCAN-1020] neon scram pgx (#5217)
  • 925c1d0 fix(detectors/docker): don't greedy match in keyPat (#5214)
  • e12da3c docs: add generic config-secret custom detector example (#5195)
  • bcbcab2 Fix GHEC with Data Residency (*.ghe.com) base URL (#4777)
  • bc3a3ae Update module github.com/go-git/go-git/v5 to v5.19.2 [SECURITY] (#5196)
  • See full diff in compare view

@dependabot @github

dependabot Bot commented on behalf of github Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Labels

The following labels could not be found: dependencies, github-actions. Please create them before Dependabot can add them to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@github-actions

Copy link
Copy Markdown

Manual review required. This Dependabot PR bumps a version-update:semver-major dependency. Please review the changelog before approving.

@github-actions

Copy link
Copy Markdown

PR Checks Summary

Check Status
Lint & Format ⏭️ skipped
Type Check ⏭️ skipped
Unit Tests ⏭️ skipped
Build ⏭️ skipped

All checks passed! Ready for review.

@github-actions

Copy link
Copy Markdown

Security Scan Results: PASSED

Scanner Critical High
SAST 0 0
Dependencies 0 0

@acamarata

Copy link
Copy Markdown
Collaborator

Holding this one. Its green checks do not cover the change.

setup-java is used by build-capacitor.yml, build-react-native.yml, deploy-mobile-android.yml and the mobile jobs in ci.yml. On this PR every one of those is SKIPPED — the first two are workflow_dispatch-only so they never run on a PR at all, and the mobile/Android/iOS checks are path-filtered out. The checks that are green (accessibility, web E2E, unit) do not touch Java.

So I dispatched both manually against this branch. Both failed, at the Setup Java step itself:

No file in /home/runner/work/nchat/nchat matched to
[**/*.gradle*,**/gradle.properties,**/gradle-wrapper.properties,...],
make sure you have checked out the target repository

Runs: 33084779404 (Build Capacitor), 33084782035 (Build React Native).

Cause: the step passes cache: 'gradle', but no gradle files exist at that point — android/ is generated later by npx cap add android, and nothing gradle-related is tracked in the repo (git ls-files | grep -E '\.gradle|gradle-wrapper|versions.toml' is empty). In v5 that was a warning. In v6 it is a hard job failure.

This is not a reason to revert the bump; the workflows are wired wrong and v6 surfaced it. A fix is in progress that moves Setup Java after the Android project is generated, so cache: 'gradle' has real files to key on. Once that lands this can merge.

Worth noting for its own sake: these two workflows have never run on main even once, which is why this sat undetected.

Bumps the actions group with 2 updates in the / directory: [actions/setup-java](https://github.com/actions/setup-java) and [trufflesecurity/trufflehog](https://github.com/trufflesecurity/trufflehog).


Updates `actions/setup-java` from 5 to 6
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](actions/setup-java@v5...v6)

Updates `trufflesecurity/trufflehog` from 3.97.0 to 3.97.1
- [Release notes](https://github.com/trufflesecurity/trufflehog/releases)
- [Commits](trufflesecurity/trufflehog@bcfcf73...20652fb)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
- dependency-name: trufflesecurity/trufflehog
  dependency-version: 3.97.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot changed the title chore(ci): bump the actions group with 2 updates chore(ci): bump the actions group across 1 directory with 2 updates Aug 27, 2026
@dependabot
dependabot Bot force-pushed the dependabot/github_actions/actions-790f3d4e60 branch from 2660619 to 9773121 Compare August 27, 2026 15:10
@github-actions

Copy link
Copy Markdown

Manual review required. This Dependabot PR bumps a version-update:semver-major dependency. Please review the changelog before approving.

@github-actions

Copy link
Copy Markdown

Security Scan Results: PASSED

Scanner Critical High
SAST 0 0
Dependencies 0 0

acamarata added a commit that referenced this pull request Aug 27, 2026
* chore(ci): bump the actions group with 2 updates

Bumps the actions group with 2 updates: [actions/setup-java](https://github.com/actions/setup-java) and [trufflesecurity/trufflehog](https://github.com/trufflesecurity/trufflehog).


Updates `actions/setup-java` from 5 to 6
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](actions/setup-java@v5...v6)

Updates `trufflesecurity/trufflehog` from 3.97.0 to 3.97.1
- [Release notes](https://github.com/trufflesecurity/trufflehog/releases)
- [Commits](trufflesecurity/trufflehog@bcfcf73...20652fb)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
- dependency-name: trufflesecurity/trufflehog
  dependency-version: 3.97.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix(ci): move setup-java after android project generation

actions/setup-java@v5 only warned when cache: gradle found no gradle
files to key on; @v6 hard-fails the job instead. build-capacitor.yml,
build-react-native.yml, and deploy-mobile-android.yml all ran Setup
Java before the step that generates the native android/ project (via
cap add/cap sync or RN's install), so no gradle files existed yet at
that point. android/ is gitignored, never committed, so this always
happened on a fresh checkout.

Move Setup Java to run after the android project exists, matching the
pattern already used in ci.yml. Also add cache-dependency-path so the
gradle cache keys correctly once the files are present.

These workflows are workflow_dispatch-only (or tag-triggered for
deploy-mobile-android), so PR checks never exercise them and #157's
green PR checks did not catch this. Verified by dispatching
build-capacitor.yml and build-react-native.yml directly against this
branch.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@acamarata

Copy link
Copy Markdown
Collaborator

@dependabot rebase

@acamarata

Copy link
Copy Markdown
Collaborator

Superseded — every version this proposes is already on main.

Verified by diffing the branch against current main:

Action main #157
actions/setup-java v6 v6
trufflesecurity/trufflehog 20652fb… (v3.97.1) 20652fb… (v3.97.1)

Both landed via #159, which had to touch the same files to fix the ordering bug this bump exposed. The only remaining delta is a setup-java@v6 line moving position, which is why it shows CONFLICTING.

Worth recording, because the green tick here was misleading

#157's checks were green while the change was broken.

Every job that actually runs setup-java was SKIPPED on this PR: build-capacitor.yml and build-react-native.yml are workflow_dispatch-only so they never run on a PR, and the mobile/Android/iOS checks in ci.yml are path-filtered out. The green checks (accessibility, web E2E, unit) do not touch Java.

Dispatching those workflows manually against this branch failed immediately, at the Setup Java step itself:

No file in /home/runner/work/nchat/nchat matched to
[**/*.gradle*,**/gradle.properties,...], make sure you have checked out the target repository

cache: gradle was a warning in v5 and is a hard failure in v6, and the Android project is generated later by npx cap add android — nothing gradle-related is tracked in the repo at all.

#159 fixed it properly by moving Setup Java after the project is generated (matching the pattern ci.yml already used) and adding cache-dependency-path, verified by a dispatched run where Setup Java succeeded and a real Build Android (Debug) gradle build ran to artifact upload.

The trufflehog half was fine throughout — Scan for Leaked Secrets does run on PRs and was genuinely green.

@acamarata acamarata closed this Aug 27, 2026
@dependabot @github

dependabot Bot commented on behalf of github Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

To ignore these dependencies, configure ignore rules in dependabot.yml

@acamarata
acamarata deleted the dependabot/github_actions/actions-790f3d4e60 branch August 27, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant