fix(deps): raise nine override floors that advisories had outrun - #183
Merged
Merged
Conversation
Nine open Dependabot alerts on packages whose resolved version sits just below a
published fix. Each floor was correct when written; the advisories moved past it.
vitest / @vitest/{mocker,utils,coverage-v8} 4.1.8 -> 4.1.11
protobufjs 8.6.4 -> 8.6.6
qs 6.15.2 -> 6.16.0
morgan 1.10.1 -> 1.12.1
postcss-selector-parser 6.1.2 -> 6.1.4
@appium/base-driver 10.5.2 -> 10.8.0
The protobufjs entries are retargeted rather than supplemented: three of them
pinned the 8.x line to exactly 8.6.4, which is now below the fix, so adding a
separate floor would have left them fighting.
Every floor is bounded. `"vitest": ">=4.1.11"` on its own resolved to 5.0.0 — a
test-runner major arriving under a security-floor change — so the vitest family
is held to `<5.0.0`, morgan to `<2.0.0`, postcss-selector-parser to `<7.0.0` and
@appium/base-driver to `<11.0.0`. These are meant to be the smallest move that
clears each advisory.
NOT included, each needing its own decision rather than a silent rider here:
@tiptap/core 2.27.2 -> 3.30.4 major
csv-parse 4.16.3 -> 7.0.2 three majors
body-parser 1.20.5 -> 2.3.0 major; v1 has no fix, and 2.2.2 is already
resolved alongside it. Severity low.
Confirmed already fixed and left alone: sharp, resolved at 0.35.4, which is the
patched version — those two high alerts read the manifest, not the lockfile.
Verified by regenerating the lockfile and reading resolutions out of its
`packages:` section. No sibling importers were added: `pnpm-workspace.yaml`
includes `../packages/@nself/*`, no nchat workflow clones that sibling, and a
regeneration that adds those importers grows the lockfile by ~5,900 lines and
would not match what CI installs. This diff adds none.
Dependency ReviewThe following issues were found:
OpenSSF ScorecardScorecard details
Scanned Files
|
Security Scan Results: PASSED
|
PR Checks Summary
✅ All checks passed! Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(deps): raise nine override floors that advisories had outrun
Nine open Dependabot alerts on packages whose resolved version sits just below a
published fix. Each floor was correct when written; the advisories moved past it.
The protobufjs entries are retargeted rather than supplemented: three of them
pinned the 8.x line to exactly 8.6.4, which is now below the fix, so adding a
separate floor would have left them fighting.
Every floor is bounded.
"vitest": ">=4.1.11"on its own resolved to 5.0.0 — atest-runner major arriving under a security-floor change — so the vitest family
is held to
<5.0.0, morgan to<2.0.0, postcss-selector-parser to<7.0.0and@appium/base-driver to
<11.0.0. These are meant to be the smallest move thatclears each advisory.
NOT included, each needing its own decision rather than a silent rider here:
Confirmed already fixed and left alone: sharp, resolved at 0.35.4, which is the
patched version — those two high alerts read the manifest, not the lockfile.
Verified by regenerating the lockfile and reading resolutions out of its
packages:section. No sibling importers were added:pnpm-workspace.yamlincludes
../packages/@nself/*, no nchat workflow clones that sibling, and aregeneration that adds those importers grows the lockfile by ~5,900 lines and
would not match what CI installs. This diff adds none.