ci: consolidate trivial gates, add missing concurrency groups - #66
Merged
Merged
Conversation
acamarata
force-pushed
the
ci/consolidate-hygiene-gates
branch
from
September 1, 2026 23:06
ecf9671 to
3e97a8d
Compare
Fold clean-root, clean-working-tree (duplicate), multi-arch-check (stub), nself-first-check, doc-sync, and generated-file-gate into a single hygiene.yml sharing one checkout and one runner allocation per push/PR. None of the folded checks are required branch-protection checks; Gitleaks and Desktop Build Check are untouched. Add concurrency groups (cancel-in-progress) to companion-build, core-ci, desktop-e2e, llm-acceptance, security-scan, and dependabot-review, which previously had none. Left pull_request_target, publish, and release-cascade workflows alone per the cross-PR-cancellation and mid-deploy-cancel risks. No application code changed.
Matches price-lint.yml's prior explicit contents:read restriction; none of the consolidated steps need write access.
acamarata
force-pushed
the
ci/consolidate-hygiene-gates
branch
from
September 2, 2026 10:42
3e97a8d to
8b47efb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hygiene.ymlsharing a single checkout + runner allocation. None of the folded checks are required branch-protection checks.concurrencygroups (cancel-in-progress) tocompanion-build.yml,core-ci.yml,desktop-e2e.yml,llm-acceptance.yml,security-scan.yml,dependabot-review.yml, which had none.dependabot-auto-merge.yml(pull_request_target — ref-keyed group would cross-cancel unrelated PRs),publish-updater.yml/release-cascade.yml(release/publish flows — never cancel mid-flight), andquarterly-doc-audit.yml(schedule-only, not part of the per-push queueing problem) untouched.ci.yml(holds the required "Desktop Build Check" job) — left broad per the hard safety constraint.Verification
Gitleaks(own workflow, untouched) andDesktop Build Check(inci.yml, untouched).actionlinton all touched files: zero new findings vsorigin/main(pre-existing shellcheck/workflow-call findings in unrelated files — desktop-macos.yml, linux-sign.yml, publish-r2.yml, publish-updater.yml, release-cascade.yml, release.yml — are identical before/after; the only diff isdoc-sync.yml's one finding disappearing since that file now lives, lint-clean, insidehygiene.yml).Test plan
hygiene.ymlruns successfully on this PR's own checks (all 5 folded gates should PASS in one job)GitleaksandDesktop Build Checkas required and green