ci: consolidate trivial gates into hygiene.yml - #5
Merged
Merged
Conversation
clean-root.yml and generated-file-gate.yml were two separate near-instant
workflows (a few seconds of real work each) each claiming their own runner
allocation on every push/PR. Neither is a required branch-protection check
for nsentry, so they're merged into one hygiene.yml job with a single
checkout — same steps, same logic, 1 runner claim instead of 2.
Trigger scope is the union of the two originals (clean-root ran on
[main, develop], generated-file-gate on [main] only), so nothing that used
to run stops running.
ci.yml and gitleaks.yml are untouched — both carry required checks
('Lint + Typecheck + Test (client + mobile)' and 'gitleaks'). No paths
filter was added to either: GitHub does not skip a required check just
because paths-ignore excluded it from a push, it blocks the merge waiting
on a check that never runs — so path-filtering a required-check workflow
is unsafe and was deliberately not attempted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clean-root.ymlandgenerated-file-gate.yml(each a few seconds of real work, no toolchain) into onehygiene.ymljob with a single checkout — 1 runner claim per push instead of 2. Neither was a required branch-protection check.clean-rootran on[main, develop],generated-file-gateon[main]only) — broader, not narrower, so nothing that used to run stops running.ci.ymlandgitleaks.ymlare untouched.paths:filters added anywhere.hygiene.ymlneeds to see every changed file to catch a committed generated file in any path.ci.yml/gitleaks.ymlcarry required checks — GitHub does not skip a required check just becausepaths-ignoreexcluded a push from triggering it, it blocks the merge waiting on a check that never runs. Path-filtering a required-check workflow is unsafe, so it was deliberately not attempted.Safety
Lint + Typecheck + Test (client + mobile)(jobgateinci.yml) — file untouched, byte-identical toorigin/main.gitleaks(jobgitleaksingitleaks.yml) — file untouched.continue-on-error, no loosened assertions.Test plan
actionlinton all workflow files post-change: exit 0actionlinton the pre-change baseline (origin/main): exit 0 — no new findingsci.ymlandgitleaks.ymlagainstorigin/main: identical