fix(deps): browserslist override + stale lockfile resync - #6
Merged
Merged
Conversation
Two newly published HIGH advisories against browserslist <= 4.28.6 (unbounded memory growth from an unevicted query-result cache, plus a crash/prototype-write via untrusted browserslist-stats.json), patched in 4.28.7. Reached transitively via babel, so no direct dependency to bump. Overridden at the workspace root. Also resyncs the lockfile against nself-org/packages main, which added eslint + typescript-eslint devDependencies to @nself/tailwind-brand, @nself-web/csp and @nself-web/og -- pnpm install --frozen-lockfile was failing with ERR_PNPM_OUTDATED_LOCKFILE on both CI jobs (Expo bundle check, Lint+Typecheck+Test) because the checked-out sibling packages repo had moved ahead of this lockfile. Verified by the resolved lockfile version, not the config: browserslist now resolves to 4.28.8. CI=true pnpm install --frozen-lockfile exits 0 -- the exact command CI runs. pnpm audit --audit-level=high still exits non-zero (23 pre-existing HIGH findings unrelated to either fix, e.g. tar via expo/@expo/cli); auditConfig here has no ignoreCves list, so this audit gate was already failing before this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browserslist-stats.json), patched in 4.28.7. Reached transitively via babel; overridden at the workspace root.nself-org/packagesmain, which addedeslint/typescript-eslintdevDependencies to@nself/tailwind-brand,@nself-web/cspand@nself-web/og.pnpm install --frozen-lockfilewas failing withERR_PNPM_OUTDATED_LOCKFILEon both the "Expo bundle check" and "Lint + Typecheck + Test" jobs.Verification
grep -oE 'browserslist@[0-9.]+' pnpm-lock.yaml->browserslist@4.28.8.CI=true pnpm install --frozen-lockfileexits 0 (the exact command CI runs).pnpm audit --audit-level=highstill exits non-zero (23 pre-existing HIGH findings unrelated to either fix, e.g.tarviaexpo/@expo/cli); this repo'sauditConfighas noignoreCveslist, so that gate was already failing before this change and is out of scope here.Test plan