fix(deps): sync pnpm-lock.yaml with packages jsdom devDependency - #161
Merged
Merged
Conversation
…om devDependency nself-org/packages added a jsdom devDependency to @nself/offline-queue (commit 647ab84, 2026-08-31) but ntask's pnpm-lock.yaml was never regenerated against it. Every CI job re-clones nself-org/packages HEAD and runs pnpm install --frozen-lockfile against the workspace root lockfile, so all six jobs failed identically at the Install step with ERR_PNPM_OUTDATED_LOCKFILE the moment that upstream commit landed. No code change; jsdom already existed in the lockfile package graph as a vitest peer, so this only adds the missing importer specifier entry.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm install --frozen-lockfilestep withERR_PNPM_OUTDATED_LOCKFILE.nself-org/packagescommit647ab84(2026-08-31, today) added ajsdomdevDependency to@nself/offline-queue. Every CI job re-clonesnself-org/packagesHEAD fresh, so the moment that commit landed, ntask's checked-inpnpm-lock.yaml(which predates it) no longer matched.packagesHEAD. Diff is 3 lines — one missing importer specifier entry (jsdomwas already present in the lockfile's package graph as a vitest peer dependency, so nothing new was downloaded).Verification
nself-org/packagesfresh (as CI does), ranpnpm install --frozen-lockfilefrom ntask root → sameERR_PNPM_OUTDATED_LOCKFILE/jsdom@^29.1.1message as all four Tauri build logs and both Web Tests / Mobile Tests logs.pnpm install --frozen-lockfileexits 0 locally.pnpm-workspace.yamlthatapps/mobile's "Install mobile dependencies" step (which appeared to run from a different directory) still resolves the same root workspace lockfile, so one fix covers all six checks.tsctypecheck onweb/surfaced unrelated module-resolution warnings against@nself-web/uisource files that do not match this morning's green run ate11f1c0with the same recipe; this looks like a macOS/pnpm-store artifact of my local repro rather than a real regression, but I did not chase it further — letting this PR's actual CI (Linux) be the ground truth for that step.Test plan