fix(deps): override decode-uri-component to 0.5.0 for GHSA-vcc3-ghjq-m6fr - #166
Merged
Merged
Conversation
…m6fr The advisory was published after main last passed its dependency audit, so it started failing every open PR without any of them changing a dependency. Severity 6.6, and upstream has a fix, so this is an override rather than a filter entry. Follows the existing convention in the root overrides block. Verified by the resolved version in the lockfile rather than by the config alone: the lockfile now contains only decode-uri-component@0.5.0, with no remaining 0.x below 0.5.0. Overrides declared anywhere other than the workspace root are silently ignored, so checking the config would not have proved anything.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
The lockfile was stale against packages/@nself/offline-queue, which declared jsdom after this repo last resolved. CI clones the shared packages fresh, so it saw the declaration and refused the frozen install with ERR_PNPM_OUTDATED_LOCKFILE, while a local clone that was five commits behind resolved without it. That is the failure mode of cloning another repo into this one: the lockfile depends on the state of a checkout that nothing here pins. The local clone has been fast-forwarded and the lockfile regenerated against it. Verified with the command CI actually runs, pnpm install --frozen-lockfile, which now exits 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHSA-vcc3-ghjq-m6fr(severity 6.6) was published after main last passed its Dependency Audit, so it began failing every open PR without any of them touching a dependency. Upstream has a fix, so this is an override rather than a filter entry.Verified by the resolved version in the lockfile, not by the config:
pnpm-lock.yamlnow contains onlydecode-uri-component@0.5.0, with nothing below 0.5.0 remaining. Overrides declared outside the workspace root are silently ignored, so inspecting the config alone would not have proven anything.Noted while here, not changed:
apps/tv/package.jsondeclares its ownpnpm.overridesblock, which pnpm warns about on every install and does not apply. It is currently harmless because the root declares the same mapping in the scoped formntask-tv>react-native, but it is a trap for anyone who later adds a security override there expecting it to take effect.